Functional update, host and service probes #5653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ServiceMonitor.ino needs some updates for web page but works on Serial output.
devyte
requested changes
Jan 24, 2019
There was a problem hiding this comment.
@hreintke I think the approach is mostly ok, except for my comments. I'll be able to answer with more certainty once you have a more complete implementation.
Just keep pushing changes to this PR, and let me know once you want me to review again.
libraries/ESP8266mDNS/examples/LEAmDNS/mDNS_ServiceMonitor/mDNS_ServiceMonitor.ino
Outdated
Show resolved
Hide resolved
libraries/ESP8266mDNS/examples/LEAmDNS/mDNS_ServiceMonitor/mDNS_ServiceMonitor.ino
Outdated
Show resolved
Hide resolved
libraries/ESP8266mDNS/examples/LEAmDNS/mDNS_ServiceMonitor/mDNS_ServiceMonitor.ino
Outdated
Show resolved
Hide resolved
libraries/ESP8266mDNS/examples/LEAmDNS/mDNS_ServiceMonitor/mDNS_ServiceMonitor.ino
Outdated
Show resolved
Hide resolved
libraries/ESP8266mDNS/examples/LEAmDNS/mDNS_ServiceMonitor/mDNS_ServiceMonitor.ino
Outdated
Show resolved
Hide resolved
example restyle
to struct MDNSServiceInfo { MDNSServiceInfo(MDNSResponder&
Change String -> const char* at multiple locations
devyte
requested changes
Feb 1, 2019
libraries/ESP8266mDNS/src/LEAmDNS.h
Outdated
| { | ||
| std::map<String,String> tempKV; | ||
| for (auto kv = p_pMDNSResponder._answerKeyvalue(p_hServiceQuery, p_u32AnswerIndex);kv != nullptr;kv = kv->m_pNext) { | ||
| tempKV.insert(std::pair<String,String>(String(kv->m_pcKey),String(kv->m_pcValue))); |
There was a problem hiding this comment.
If you can't move to a map of const char *, use of emplace(kv->m_pcKey, kv->m_pcValue) would be better here.
devyte
requested changes
Feb 2, 2019
devyte
requested changes
Feb 3, 2019
|
@devyte : |
devyte
approved these changes
Feb 5, 2019
6 tasks
|
Excellent work everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial version for review and feedback
In the LEADNS code I added // Functional at the locations I updated